Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required go version to chain.json #1575

Open
toschdev opened this issue Mar 10, 2023 · 1 comment
Open

Add required go version to chain.json #1575

toschdev opened this issue Mar 10, 2023 · 1 comment

Comments

@toschdev
Copy link
Contributor

Not sure how viable this is. IMO this could be very helpful to know which go version needs to be installed to run the binaries or compile the codebase.
Is that something other people would want? Leave a thumps up 👍

@greg-szabo
Copy link
Member

I'm a bit torn on this one.

On one hand, I agree, if there are specific Go requirements, it would be nice to have them in the chain registry so we don't find out during the build process.

On the other hand, I didn't really see a viable Go version restriction since about Go 1.13. The current restrictions in Makefiles are mostly because dev teams didn't get the chance to test their source code with a newer version. (When I removed the restriction, the source code built fine with the latest Go.)

I keep encouraging dev teams to only support the latest Go version with their source code at all times. (And remove manual version checks.) I understand it's not always feasible, but if not absolutely necessary, I'd rather not try to gatekeep by the Go version number.

So, sure, let's do this, if it's necessary. Or get rid of checks and only support the latest, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants