From 3198556cb20fdb6f150718d2a09aa96ea7b469a5 Mon Sep 17 00:00:00 2001
From: Bryan White <bryanchriswhite@gmail.com>
Date: Fri, 18 Oct 2024 21:54:27 +0200
Subject: [PATCH] refactor: replace comet38 begin/end_block_events with
 finalize_block_events

---
 packages/tendermint-rpc/src/comet38/adaptor/responses.ts  | 6 ++----
 packages/tendermint-rpc/src/comet38/comet38client.spec.ts | 3 +--
 packages/tendermint-rpc/src/comet38/responses.ts          | 3 +--
 3 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/packages/tendermint-rpc/src/comet38/adaptor/responses.ts b/packages/tendermint-rpc/src/comet38/adaptor/responses.ts
index a83de829bf..cb369bef12 100644
--- a/packages/tendermint-rpc/src/comet38/adaptor/responses.ts
+++ b/packages/tendermint-rpc/src/comet38/adaptor/responses.ts
@@ -287,8 +287,7 @@ export function decodeValidatorUpdate(data: RpcValidatorUpdate): responses.Valid
 interface RpcBlockResultsResponse {
   readonly height: string;
   readonly txs_results: readonly RpcTxData[] | null;
-  readonly begin_block_events: readonly RpcEvent[] | null;
-  readonly end_block_events: readonly RpcEvent[] | null;
+  readonly finalize_block_events: readonly RpcEvent[] | null;
   readonly validator_updates: readonly RpcValidatorUpdate[] | null;
   readonly consensus_param_updates: RpcConsensusParams | null;
 }
@@ -299,8 +298,7 @@ function decodeBlockResults(data: RpcBlockResultsResponse): responses.BlockResul
     results: (data.txs_results || []).map(decodeTxData),
     validatorUpdates: (data.validator_updates || []).map(decodeValidatorUpdate),
     consensusUpdates: may(decodeConsensusParams, data.consensus_param_updates),
-    beginBlockEvents: decodeEvents(data.begin_block_events || []),
-    endBlockEvents: decodeEvents(data.end_block_events || []),
+    finalizeBlockEvents: decodeEvents(data.finalize_block_events || [])
   };
 }
 
diff --git a/packages/tendermint-rpc/src/comet38/comet38client.spec.ts b/packages/tendermint-rpc/src/comet38/comet38client.spec.ts
index 3d411432dd..aa65fc241f 100644
--- a/packages/tendermint-rpc/src/comet38/comet38client.spec.ts
+++ b/packages/tendermint-rpc/src/comet38/comet38client.spec.ts
@@ -261,8 +261,7 @@ function defaultTestSuite(rpcFactory: () => RpcClient, expected: ExpectedValues)
       const results = await client.blockResults(height);
       expect(results.height).toEqual(height);
       expect(results.results).toEqual([]);
-      expect(results.beginBlockEvents).toEqual([]);
-      expect(results.endBlockEvents).toEqual([]);
+      expect(results.finalizeBlockEvents).toEqual([]);
 
       client.disconnect();
     });
diff --git a/packages/tendermint-rpc/src/comet38/responses.ts b/packages/tendermint-rpc/src/comet38/responses.ts
index 3477ba6bf8..fd35dc4006 100644
--- a/packages/tendermint-rpc/src/comet38/responses.ts
+++ b/packages/tendermint-rpc/src/comet38/responses.ts
@@ -60,8 +60,7 @@ export interface BlockResultsResponse {
   readonly results: readonly TxData[];
   readonly validatorUpdates: readonly ValidatorUpdate[];
   readonly consensusUpdates?: ConsensusParams;
-  readonly beginBlockEvents: readonly Event[];
-  readonly endBlockEvents: readonly Event[];
+  readonly finalizeBlockEvents: readonly Event[];
 }
 
 export interface BlockSearchResponse {