-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use linxGnu/grocksdb instead of gorocksdb #11683
Comments
Happy to work on this. I should mention: From every metric I can find (iavl benchmarks and state syncing osmo/gaia (tho both seem broke, both apply snapshots fastest with pebble)) PebbleDB is in fact preferable to RocksDB. Trouble is, I think there is a bug in my implementation. |
pebbledb is better event than linuxgnu/grocksdb? |
can we not upstream to the cosmos fork? im wary of switching forks every few months. |
This. |
Lets upstream and create a new release. Happy to coordinate this |
It is not upstreamable They are separate git histories. I mean we could just replace our whole repo.... but that doesn't seem like a great idea. linxGnu/grocksdb is very well-maintained. So maybe instead of creating our own fork of it, we should consider a donation to its author? |
this is part of cosmos-db |
Summary
We forked tecbot/gorocksdb (which doesn't have any activity any more) to add
OptimisticTransactionDB::NewCheckpoint
functionality.There is https://github.com/linxGnu/grocksdb which is also a fork of tecbot/gorocksdb, is active and supports the latest Rocksdb (v7) and provides additional optimizations.
Objective
Update
cosmos-sdk/db
to support https://github.com/linxGnu/grocksdb or fork it into cosmos, addOptimisticTransactionDB::NewCheckpoint
and use it instead ofcosmos/gorocksdb
.Ref: osmosis-labs/osmosis#695
CC: @faddat , @roysc
For Admin Use
The text was updated successfully, but these errors were encountered: