[Feature]: pass protocol version to cometbft

[yihuang]

Summary

x/upgrade maintains an increasing protocol version number, it's set to BaseApp.appVersion, but it's not passed to cometbft, so it's never shown in http://127.0.0.1:26657/abci_info, and not included in block header.

Problem Definition

Proposal

• Initialize BaseApp.appVersion from x/upgrade's current state.
• Pass to cometbft through block delivery response when it's changed.

[alexanderbez]

cc @cmwaters

[tac0turtle]

callum has a pr to move app version out of upgrade module into consensus module, i believe this way it will get the data and pass it to comet when its required

[lucaslopezf]

Hi @yihuang !

This issue has been resolved in the following PR: cosmos/cosmos-sdk#16244.

The protocol version is updated during an upgrade process. This is handled in the x/upgrade module, specifically in the ApplyUpgrade method of the Keeper: ApplyUpgrade

When an upgrade is applied, the protocol version is incremented and stored. This ensures that the application is aware of the new protocol version after an upgrade.
The updated protocol version is then notified in the EndBlock, as the PR shows, and the protocol version is also displayed in the abci_info endpoint (this is achieved by retrieving the protocol version in the Info method of BaseApp: abciInfo )

To validate this implementation, the following steps were performed:

1. Start a Cosmos node
2. Perform an Upgrade
3. Query abci_info endpoint

The result of querying the abci_info endpoint after severals upgrades is shown in the following image:

Please confirm if this addresses your concerns and if the issue can be closed, thanks!

[educlerici-zondax]

hi @yihuang were you able to take a look at lucas's answer?

[julienrbrt]

Hey, this has been implemented in baseapp indeed. I'll open another issue for v2.