Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: checkHeader at baseApp.CreateQueryContext should not be enabled by default #22693

Open
1 task done
beer-1 opened this issue Nov 29, 2024 · 0 comments
Open
1 task done
Labels

Comments

@beer-1
Copy link
Contributor

beer-1 commented Nov 29, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

When we use query endpoint, there are a lot of case the query comes during commit and this could lead checkHeader to be failed frequently.

func (app *BaseApp) CreateQueryContextWithCheckHeader(height int64, prove, checkHeader bool) (sdk.Context, error) {

"header height in all state context is not latest height (%d)", lastBlockHeight,

I also saw this PR, so rather to have this by default we can make new flag or params when we receive request like x-cosmos-block-height.

Cosmos SDK Version

main, v0.52

How to reproduce?

In this PR tests here, change CreateQueryContextWithCheckHeader to CreateQueryContext.

@beer-1 beer-1 added the T:Bug label Nov 29, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant