Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit impl convert::From<CouchbaseError> for io::Error #24

Open
daschl opened this issue Mar 20, 2017 · 2 comments
Open

Revisit impl convert::From<CouchbaseError> for io::Error #24

daschl opened this issue Mar 20, 2017 · 2 comments

Comments

@daschl
Copy link
Contributor

daschl commented Mar 20, 2017

We have a basic impl, but it makes sense to revisit all the different combinations and make sure they are exhaustively covered.
@adamhjk
Copy link
Contributor

adamhjk commented Oct 16, 2019

Out of curiosity - why is there a blanket From for CouchbaseError to io::Error?

@daschl
Copy link
Contributor Author

daschl commented Oct 17, 2019

@adamhjk good question, I think at the time I thought this was a good idea to make it easier for users. But these days I'm not so sure anymore - definitely before a 1.0 release the whole error handling needs to be revisited (especially the names and types of error codes themselves)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamhjk @daschl