Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snapshots #424

Closed
20 of 36 tasks
ptbrowne opened this issue Apr 17, 2018 · 7 comments
Closed
20 of 36 tasks

Add snapshots #424

ptbrowne opened this issue Apr 17, 2018 · 7 comments
Assignees
@drazik
Labels
✨ enhancement

Comments

@ptbrowne
Copy link
Contributor

ptbrowne commented Apr 17, 2018 •
edited
Loading

  • Check out snapguidist to see if it could be useful.

  • Add snapshots to existing components

  • ActionMenu ⚠️ Not shown in styleguidist so not tested properly

  • Alerter

  • Avatar

  • Badge

  • Button

  • ButtonAction

  • Checkbox

  • Field

  • Hero

  • I18n

  • Icon

  • Input

  • IntentHeader

  • IntentIframe

  • IntentModal

  • IntentOpener

  • Label

  • ListItemText

  • Media

  • Menu

  • MidEllipsis

  • Modal

  • Nav

  • Overlay

  • Panel

  • Radio

  • SelectBox

  • SelectionBar

  • Sidebar

  • Spinner

  • Tabs

  • Text

  • Textarea

  • Toggle
@gregorylegarec gregorylegarec mentioned this issue Apr 17, 2018
Merged
@gregorylegarec
Copy link
Contributor

Actually, the main idea of Snapgitdist is to show snapshot in Styleguide.

It does not allow to run automated tests or snapshot comparisons, and cannot be set up to be used for Continuous Integration.

See styleguidist/snapguidist#16 ans styleguidist/react-styleguidist#877

@ptbrowne
Copy link
Contributor Author

Adding snapshots could still be useful no ?

@ptbrowne ptbrowne reopened this Apr 17, 2018
@gregorylegarec
Copy link
Contributor

@ptbrowne You mean, in styleguidist ?

@ptbrowne
Copy link
Contributor Author

No, in general, to components

@ptbrowne
Copy link
Contributor Author

related #452

@GoOz
Copy link
Contributor

GoOz commented Jun 29, 2018

Is this issue still relevent since #452 has been done & merged?

@ptbrowne
Copy link
Contributor Author

I think we can close

@ptbrowne ptbrowne mentioned this issue Aug 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drazik drazik

Labels
✨ enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ptbrowne @gregorylegarec @GoOz @drazik