Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TranslatorVersion is missing from Library ELM JSON #1186

Closed
RohitKandimalla opened this issue Aug 14, 2023 · 8 comments
Closed

TranslatorVersion is missing from Library ELM JSON #1186

RohitKandimalla opened this issue Aug 14, 2023 · 8 comments
Assignees
Labels
bug input needed The issue needs more input from the submitter or another participant md impact tracking The issue is impacting measure development

Comments

@RohitKandimalla
Copy link

After generating ELM JSON and ELM XML using CQL-ELM-Translator, Looks like translatorVersion is missing from ELM JSON, but is present in ELM XML.

Example translatorVerison="2.11.0" is available in elm-xml
<annotation translatorVersion="2.11.0" translatorOptions="EnableAnnotations,EnableLocators,EnableResultTypes,EnableDetailedErrors,DisableListDemotion,DisableListPromotion" xsi:type="a:CqlToElmInfo"/>

It is expected that ELM JSON should also contain information related to translated version.

Please advice

MADiE team received an HelpDesk ticket regarding the same BONNIEMAT-1563

@JPercival JPercival added bug input needed The issue needs more input from the submitter or another participant labels Aug 17, 2023
@JPercival
Copy link
Contributor

Hi @RohitKandimalla!

Have you validated that the the ELM was generated with the EnabledAnnotations flag enabled?

@RohitKandimalla
Copy link
Author

I will verify that and get back to you, Is the EnabledAnnotations specific to ELMJson ?

@RohitKandimalla
Copy link
Author

@JPercival Yes, I verified and ELM is generated using EnabledAnnotations=true

@jenseeman jenseeman added the md impact tracking The issue is impacting measure development label Aug 24, 2023
@brynrhodes
Copy link
Member

@RohitKandimalla can you please post a snippet of the JSON that does not have the translator version? I'm wondering if this is related to the other JSON ELM serialization issue?

@RohitKandimalla
Copy link
Author

Hi Bryn,

Sorry for the late reply, I was not receiving the notifications.

but Idk how to post a snippet if it is not there,
so here is the comparison b/w XML and JSON of the ELM, Looks like "Annotations" object itself is missing from JSON.

I am also attaching the json
ELM_With_no_version_invormation.txt

image

@RohitKandimalla
Copy link
Author

RohitKandimalla commented Oct 6, 2023

This is a snippet provided by user, I am trying to use translator version 2.9.0, but I can't seem to reproduce it.
I also tried using all versions from v2.2.0 - v2.11.0, but I am not seeing any translatorVersion information in JSON, although it is always available in XML.
{
"library" : {
"annotation" : [ {
"translatorVersion" : "2.9.0", ...

@brynrhodes brynrhodes self-assigned this Oct 11, 2023
@ddieppois
Copy link

I tested this translation locally and was able to get the "translatorVersion" : "3.3.0-SNAPSHOT", added to the JSON. I tried it from the ChlamydiaScreening_Common.cql with the added option "-format JSON" added. The value was provided in the JSON.

Could you guys try it again with the latest version of the translator ?

@mdnazmulkarim
Copy link
Contributor

Tested it on master and it is now rendering the translatorVersion to Json and Xml. Thus it is closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug input needed The issue needs more input from the submitter or another participant md impact tracking The issue is impacting measure development
Projects
None yet
Development

No branches or pull requests

6 participants