From 05eac1cee406466683871b59fa70362a1c395ed2 Mon Sep 17 00:00:00 2001 From: birick1 <109760379+birick1@users.noreply.github.com> Date: Thu, 22 Aug 2024 14:48:10 -0400 Subject: [PATCH 1/2] Change Bonnie to MADiE in Pull Request Template Resolve #321 --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 10d7ad8b5..9d4b58e8c 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,7 +2,7 @@ Pull requests into cql-execution require the following. Submitter and reviewer should ✔ when done. For items that are not-applicable, mark "N/A" and ✔. -[CDS Connect](https://cds.ahrq.gov/cdsconnect) and [Bonnie](https://github.com/projecttacoma/bonnie) are the main users of this repository. +[CDS Connect](https://cds.ahrq.gov/cdsconnect) and [MADiE](https://www.emeasuretool.cms.gov/madie) are the main users of this repository. It is strongly recommended to include a person from each of those projects as a reviewer. **Submitter:** From fd1601edc84eac8c23e4ba9f27852e93cf84442d Mon Sep 17 00:00:00 2001 From: Brian Irick Date: Thu, 29 Aug 2024 16:00:05 -0400 Subject: [PATCH 2/2] Following discussion, remove reviewer paragraph --- .github/pull_request_template.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 9d4b58e8c..be8533f00 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,10 +2,8 @@ Pull requests into cql-execution require the following. Submitter and reviewer should ✔ when done. For items that are not-applicable, mark "N/A" and ✔. -[CDS Connect](https://cds.ahrq.gov/cdsconnect) and [MADiE](https://www.emeasuretool.cms.gov/madie) are the main users of this repository. -It is strongly recommended to include a person from each of those projects as a reviewer. - **Submitter:** + - [ ] This pull request describes why these changes were made - [ ] Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.) - [ ] Tests are included and test edge cases @@ -18,6 +16,7 @@ It is strongly recommended to include a person from each of those projects as a **Reviewer:** Name: + - [ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose - [ ] The tests appropriately test the new code, including edge cases - [ ] You have tried to break the code