-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please make unaligned access configurable #47
Comments
Does branch 'force_aligned' solve your issues? You will need to add |
@cr-marcstevens Yep, that would fine (and I agree sticking with the |
We should merge this change back into master. @peff are you ready to take these changes back into Git now? |
@shumow Yeah, as soon as this is merged, I can take care of the Git side of things. |
@cr-marcstevens I see that there watson checks haven't been run on these changes yet? Has the watson integration been turned off for this branch/project? Marc, if you're happy with the change, I'm happy to merge it back into master. Of course, pending figuring out what's up with the watson checks. |
@shumow I have received emails from TravisCI that both commits in the branch have passed, so TravisCI is still working. If everyone is happy then I'll merge it now. |
Ahh, yeah -- Travis, not watson. (Can't keep all these proper names straight.) As long as you can confirm it, that's fine. |
Thanks for the quick turnaround! The Git patch is at https://public-inbox.org/git/[email protected]/. |
Per a discussion on Git mailing list at One failed self test on Fedora 29 and assorted follow-ups. The discussion concerns itself with a failed audit due to unaligned accesses in
sha1dc/sha1.c
(usingCFLAGS += -fsanitize=undefined
).And in particular, from Jeff King at disabling sha1dc unaligned access:
Please provide an option to disable unaligned accesses.
The text was updated successfully, but these errors were encountered: