Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord Notification formatting got messed up (Edge) #970

Closed
3 tasks done
rg9400 opened this issue Sep 17, 2023 · 6 comments · Fixed by #984
Closed
3 tasks done

Discord Notification formatting got messed up (Edge) #970

rg9400 opened this issue Sep 17, 2023 · 6 comments · Fixed by #984
Labels

Comments

@rg9400
Copy link

rg9400 commented Sep 17, 2023

Support guidelines

I've found a bug and checked that ...

  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

Formatting for Discord notification messages (not the embed) got disturbed in one of the recent Edge releases. The first image is the last properly formatted notification, so it's where the bug was introduced.

Before:
image

After:
image

Expected behaviour

Formatting should not be disturbed, so it should look like the first image

Actual behaviour

It looks like the second image

Steps to reproduce

  1. Update Diun to latest Edge
  2. Set up Discord notification webhooks
  3. Have a new image be updated
  4. Verify formatting of Discord notification

Diun version

v4.25.0-71-gc78d877

Docker info

I do not believe this is relevant, but I can provide if so

Docker Compose config

Not relevant

Logs

Not relevant (can provide if deemed relevant, but I think this is just a notification formatting error)

Additional info

No response

@crazy-max
Copy link
Owner

crazy-max commented Sep 23, 2023

Thanks for your report!

Ok so v4.25.0-79-g54a61c4 is the actual version where it seems broken. That's odd though, I can't find the commit id g54a61c4 in the working tree.

But anyway, I think this could be linked to #927. Can you try with edge again to see if you still repro with latest changes by any chance? And latest as well to see if this is not an upstream breaking change.

@rg9400
Copy link
Author

rg9400 commented Sep 23, 2023

It's still broken on v4.25.0-113-g42d16db
image

Running latest tag with v4.25.0 works fine
image

@crazy-max
Copy link
Owner

Thanks I'm taking a look

@crazy-max
Copy link
Owner

@rg9400 If you want to pull edge again, this should be fixed.

@rg9400
Copy link
Author

rg9400 commented Sep 23, 2023

@crazy-max can confirm, it is fixed now. Thanks!

@crazy-max
Copy link
Owner

And thank you for testing edge releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants