Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the secondary navigations reactive. #536

Open
Dhruvi16 opened this issue Oct 6, 2020 · 7 comments
Open

Make the secondary navigations reactive. #536

Dhruvi16 opened this issue Oct 6, 2020 · 7 comments
Labels
💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software 🌟 goal: addition Addition of new feature ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 💪 skill: javascript Requires proficiency in 'JavaScript' 🚧 status: blocked Blocked & therefore, not ready for work

Comments

@Dhruvi16
Copy link
Member

Dhruvi16 commented Oct 6, 2020

Problem

The guidelines pages have table of contents and that does not show what section is active right now.

Description

Make the table of content and table of progress reactive. This will highlight the active section as the user scrolls. Here is a similar demo.

Additional context

@Dhruvi16 Dhruvi16 added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository labels Oct 6, 2020
@Dhruvi16 Dhruvi16 self-assigned this Oct 6, 2020
@Dhruvi16 Dhruvi16 added 🌟 goal: addition Addition of new feature 💪 skill: javascript Requires proficiency in 'JavaScript' 🕹 aspect: interface Concerns end-users' experience with the software labels Oct 6, 2020
@kgodey kgodey added 🏁 status: ready for work Ready for work and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 16, 2020
@kenkirito

This comment was marked as outdated.

@dhruvkb

This comment was marked as outdated.

@kenkirito

This comment was marked as outdated.

@Arpitchugh

This comment was marked as outdated.

@dhruvkb

This comment was marked as outdated.

@TimidRobot TimidRobot added the help wanted Open to participation from the community label Jul 10, 2023
@TimidRobot TimidRobot moved this to Backlog in Applications Sep 10, 2024
@nazarenegena
Copy link

@TimidRobot I would like further clarification regarding the specific implementation since the active link on the guidelines changes to black while active, essentially according to the demo should the background also change color when the link is active ? and should i change the active link color from black ?

@TimidRobot TimidRobot added this to WebDev Oct 8, 2024
@TimidRobot TimidRobot moved this to Backlog in WebDev Oct 8, 2024
@TimidRobot TimidRobot added 🚧 status: blocked Blocked & therefore, not ready for work and removed help wanted Open to participation from the community 🏁 status: ready for work Ready for work labels Oct 9, 2024
@TimidRobot
Copy link
Member

@nazarenegena the current Vocabulary design system doesn't have an implementation yet.

🚧 status: blocked Blocked & therefore, not ready for work because I think this should be solved upstream first:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software 🌟 goal: addition Addition of new feature ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 💪 skill: javascript Requires proficiency in 'JavaScript' 🚧 status: blocked Blocked & therefore, not ready for work
Projects
Status: Backlog
Status: Backlog
Development

Successfully merging a pull request may close this issue.

8 participants
@kgodey @TimidRobot @dhruvkb @Dhruvi16 @Arpitchugh @nazarenegena @kenkirito and others