Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implements close icon for vocabulary #311

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

egbadon-victor
Copy link
Contributor

Fixes

Description

This PR adds a close icon to to the vocabulary source files.

Technical details

The SVG implementation was gotten from the official font awesome website, then resizes to be compatibility with the existing viewBox="0 0 30 30" property.

Tests

  • Launch the project on your browser on your local machine
  • Go to any test context, and implement a close icon using the following code
    <span class="icon-replace fa-close">Close</span>
    -Observe the close icon displays properly

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@egbadon-victor egbadon-victor requested review from a team as code owners November 8, 2024 13:10
@egbadon-victor egbadon-victor requested review from TimidRobot, possumbilities and nimishbongale and removed request for a team November 8, 2024 13:10
Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit cec3d69
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/673b1b060e59d20008abb955
😎 Deploy Preview https://deploy-preview-311--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Feature] Include Close Icon in the vocabulary design system
1 participant