Trailing comments are lost

[pd4d10]

Like this:

namespace js test // trailing comment

Output:

{
  "type": "ThriftDocument",
  "body": [
    {
      "type": "NamespaceDefinition",
      "scope": {
        "type": "Identifier",
        "value": "js",
        "loc": {
          "start": {
            "line": 1,
            "column": 11,
            "index": 10
          },
          "end": {
            "line": 1,
            "column": 13,
            "index": 12
          }
        }
      },
      "name": {
        "type": "Identifier",
        "value": "test",
        "loc": {
          "start": {
            "line": 1,
            "column": 14,
            "index": 13
          },
          "end": {
            "line": 1,
            "column": 18,
            "index": 17
          }
        }
      },
      "comments": [],
      "loc": {
        "start": {
          "line": 1,
          "column": 1,
          "index": 0
        },
        "end": {
          "line": 1,
          "column": 18,
          "index": 17
        }
      }
    }
  ]
}

[pd4d10]

Comment interface now has only type and value. How about adding a property called position, like this:

export interface CommentLine extends SyntaxNode {
  type: SyntaxType.CommentLine
  value: string
  position: 'leading' | 'trailing' // Added
}

Just a proposal. If OK, I could try to submit a PR to fix this

[kevin-greene-ck]

This sounds good to me. I'm not personally using the parsed comments at the moment, but this certainly seems the least invasive way to add this information. If I was doing this from the start I would have added leadingComments and trailingComments properties to the nodes to mimic what Babylon/TSC does with JS.

A PR would be greatly appreciated.