Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discussion] keep block comments' original content? #53

Open
pd4d10 opened this issue Sep 25, 2018 · 1 comment
Open

[discussion] keep block comments' original content? #53

pd4d10 opened this issue Sep 25, 2018 · 1 comment

Comments

@pd4d10
Copy link
Contributor

pd4d10 commented Sep 25, 2018

Take part of this file as example:

/*
 * with the License. You may obtain a copy of the License at
 *
 *   http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing,
 */
 
namespace c_glib TTest

The comment block is parsed to:

        {
          "type": "CommentBlock",
          "value": [
            "with the License. You may obtain a copy of the License at",
            "*",
            " http://www.apache.org/licenses/LICENSE-2.0",
            "*",
            " Unless required by applicable law or agreed to in writing,"
          ]
        }

The indent of http://www.apache.org/licenses/LICENSE-2.0 is intended, which is lost. Maybe it is better to keep block comments' original content?

@pd4d10 pd4d10 changed the title [discussion] keep comments' original content? [discussion] keep block comments' original content? Sep 25, 2018
@kevin-greene-ck
Copy link
Contributor

Trying to parse the comment body was probably a mistake. Something I can look to add quickly is a new property rawValue that would have the unparsed comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants