Feature/add google access context manager resources #331

bradkwadsworth-mw · 2023-07-06T18:49:42Z

Description of your changes

Added accesscontextmanager resources including accesslevel, accesslevelcondition, accesspolicy, accesspolicyiammember, serviceperimeter, and serviceperimeterresource.

Moves 6 out of 7 resources in this issue to the v1beta1 version.

I have:

Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Created the resources inside a GCP org.

accesslevel

Conditions:
    Last Transition Time:  2023-07-20T14:05:45Z
    Reason:                Available
    Status:                True
    Type:                  Ready
    Last Transition Time:  2023-07-20T14:05:37Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
    Last Transition Time:  2023-07-20T14:05:40Z
    Reason:                Success
    Status:                True
    Type:                  LastAsyncOperation
    Last Transition Time:  2023-07-20T14:05:40Z
    Reason:                Finished
    Status:                True
    Type:                  AsyncOperation
Events:
  Type     Reason                       Age                From                                                                   Message
  ----     ------                       ----               ----                                                                   -------
  Normal   CreatedExternalResource      36m                managed/accesscontextmanager.gcp.upbound.io/v1beta1, kind=accesslevel  Successfully requested creation of external resource
  Warning  CannotUpdateManagedResource  36m                managed/accesscontextmanager.gcp.upbound.io/v1beta1, kind=accesslevel  Operation cannot be fulfilled on accesslevels.accesscontextmanager.gcp.upbound.io "access-level": the object has been modified; please apply your changes to the latest version and try again
  Normal   UpdatedExternalResource      16m (x2 over 26m)  managed/accesscontextmanager.gcp.upbound.io/v1beta1, kind=accesslevel  Successfully requested update of external resource

accesslevelcondition

Conditions:
    Last Transition Time:  2023-07-20T14:10:40Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
    Last Transition Time:  2023-07-20T14:32:23Z
    Reason:                Available
    Status:                True
    Type:                  Ready
    Last Transition Time:  2023-07-20T14:12:28Z
    Reason:                Finished
    Status:                True
    Type:                  AsyncOperation
    Last Transition Time:  2023-07-20T14:12:28Z
    Reason:                Success
    Status:                True
    Type:                  LastAsyncOperation
Events:
  Type     Reason                         Age                 From                                                                            Message
  ----     ------                         ----                ----                                                                            -------
  Warning  CannotObserveExternalResource  32m (x6 over 32m)   managed/accesscontextmanager.gcp.upbound.io/v1beta1, kind=accesslevelcondition  cannot run refresh: refresh failed: Reference to undeclared resource: A managed resource "google_service_account" "created-later" has not been declared in the root module.
  Normal   PendingExternalResource        30m (x15 over 32m)  managed/accesscontextmanager.gcp.upbound.io/v1beta1, kind=accesslevelcondition  Waiting for external resource existence to be confirmed
  Normal   CreatedExternalResource        19m (x5 over 32m)   managed/accesscontextmanager.gcp.upbound.io/v1beta1, kind=accesslevelcondition  Successfully requested creation of external resource
  Normal   CreatedExternalResource        10m                 managed/accesscontextmanager.gcp.upbound.io/v1beta1, kind=accesslevelcondition  Successfully requested creation of external resource

accesspolicy

Conditions:
    Last Transition Time:  2023-07-20T13:58:30Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
    Last Transition Time:  2023-07-20T14:03:59Z
    Reason:                Available
    Status:                True
    Type:                  Ready
    Last Transition Time:  2023-07-20T14:03:20Z
    Reason:                Finished
    Status:                True
    Type:                  AsyncOperation
    Last Transition Time:  2023-07-20T14:03:53Z
    Reason:                Success
    Status:                True
    Type:                  LastAsyncOperation
Events:
  Type     Reason                   Age                 From                                                                    Message
  ----     ------                   ----                ----                                                                    -------
  Warning  CannotConnectToProvider  46m (x7 over 47m)   managed/accesscontextmanager.gcp.upbound.io/v1beta1, kind=accesspolicy  cannot get terraform setup: cannot get referenced ProviderConfig: ProviderConfig.gcp.upbound.io "default" not found
  Normal   CreatedExternalResource  43m (x3 over 44m)   managed/accesscontextmanager.gcp.upbound.io/v1beta1, kind=accesspolicy  Successfully requested creation of external resource

accesspolicyiammember

Conditions:
    Last Transition Time:  2023-07-20T14:39:17Z
    Reason:                Available
    Status:                True
    Type:                  Ready
    Last Transition Time:  2023-07-20T14:39:03Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
    Last Transition Time:  2023-07-20T14:39:10Z
    Reason:                Success
    Status:                True
    Type:                  LastAsyncOperation
    Last Transition Time:  2023-07-20T14:39:10Z
    Reason:                Finished
    Status:                True
    Type:                  AsyncOperation
Events:
  Type     Reason                       Age    From                                                                             Message
  ----     ------                       ----   ----                                                                             -------
  Normal   CreatedExternalResource      5m16s  managed/accesscontextmanager.gcp.upbound.io/v1beta1, kind=accesspolicyiammember  Successfully requested creation of external resource
  Warning  CannotUpdateManagedResource  5m7s   managed/accesscontextmanager.gcp.upbound.io/v1beta1, kind=accesspolicyiammember  Operation cannot be fulfilled on accesspolicyiammembers.accesscontextmanager.gcp.upbound.io "accesspolicy-iam-member": the object has been modified; please apply your changes to the latest version and try again

serviceperimeter

Conditions:
    Last Transition Time:  2023-07-20T14:39:12Z
    Reason:                Available
    Status:                True
    Type:                  Ready
    Last Transition Time:  2023-07-20T14:39:02Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
    Last Transition Time:  2023-07-20T14:39:06Z
    Reason:                Success
    Status:                True
    Type:                  LastAsyncOperation
    Last Transition Time:  2023-07-20T14:39:06Z
    Reason:                Finished
    Status:                True
    Type:                  AsyncOperation
Events:
  Type     Reason                       Age    From                                                                        Message
  ----     ------                       ----   ----                                                                        -------
  Normal   CreatedExternalResource      5m38s  managed/accesscontextmanager.gcp.upbound.io/v1beta1, kind=serviceperimeter  Successfully requested creation of external resource
  Warning  CannotUpdateManagedResource  5m32s  managed/accesscontextmanager.gcp.upbound.io/v1beta1, kind=serviceperimeter  Operation cannot be fulfilled on serviceperimeters.accesscontextmanager.gcp.upbound.io "service-perimeter": the object has been modified; please apply your changes to the latest version and try again

serviceperimeterresource

Conditions:
    Last Transition Time:  2023-07-20T14:41:07Z
    Reason:                Available
    Status:                True
    Type:                  Ready
    Last Transition Time:  2023-07-20T14:40:59Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
    Last Transition Time:  2023-07-20T14:41:02Z
    Reason:                Success
    Status:                True
    Type:                  LastAsyncOperation
    Last Transition Time:  2023-07-20T14:41:02Z
    Reason:                Finished
    Status:                True
    Type:                  AsyncOperation
Events:
  Type     Reason                       Age    From                                                                                Message
  ----     ------                       ----   ----                                                                                -------
  Normal   CreatedExternalResource      4m2s   managed/accesscontextmanager.gcp.upbound.io/v1beta1, kind=serviceperimeterresource  Successfully requested creation of external resource
  Warning  CannotUpdateManagedResource  3m57s  managed/accesscontextmanager.gcp.upbound.io/v1beta1, kind=serviceperimeterresource  Operation cannot be fulfilled on serviceperimeterresources.accesscontextmanager.gcp.upbound.io "service-perimeter-resource": the object has been modified; please apply your changes to the latest version and try again

jeanduplessis · 2023-07-07T07:53:46Z

/test-examples="examples/accesscontextmanager/accesslevel.yaml,examples/accesscontextmanager/accesslevelcondition.yaml,examples/accesscontextmanager/accesspolicy.yaml,examples/accesscontextmanager/serviceperimeter.yaml,examples/accesscontextmanager/serviceperimeterresource.yaml"

turkenf

Thank you @bradkwadsworth-mw for this PR, I left a few comments for you to consider.

config/accesscontextmanager/config.go

config/externalname.go

examples/accesscontextmanager/accesslevel.yaml

examples/accesscontextmanager/accesslevelcondition.yaml

examples/accesscontextmanager/serviceperimeter.yaml

examples/accesscontextmanager/serviceperimeterresource.yaml

examples/accesscontextmanager/accesslevel.yaml

config/accesscontextmanager/config.go

turkenf

@bradkwadsworth-mw thank you very much for the quick update, I left two small comments and could you please make sure that the final state of the examples is working?

examples/accesscontextmanager/accesslevelcondition.yaml

examples/accesscontextmanager/serviceperimeter.yaml

bradkwadsworth-mw · 2023-07-18T20:42:28Z

/test-examples="examples/accesscontextmanager/accesslevel.yaml,examples/accesscontextmanager/accesslevelcondition.yaml,examples/accesscontextmanager/accesspolicy.yaml,examples/accesscontextmanager/serviceperimeter.yaml,examples/accesscontextmanager/serviceperimeterresource.yaml"

turkenf · 2023-07-19T07:58:49Z

/test-examples="examples/accesscontextmanager/accesslevel.yaml,examples/accesscontextmanager/accesslevelcondition.yaml,examples/accesscontextmanager/accesspolicy.yaml,examples/accesscontextmanager/serviceperimeter.yaml,examples/accesscontextmanager/serviceperimeterresource.yaml"

FYI: When we add upjet.upbound.io/manual-intervention to the example manifests of the resources, the uptest will automatically skip and the test will show as green, so there is no point in triggering the uptest in the examples containing manual-intervention. We need to test these resources manually.

turkenf · 2023-07-19T08:56:14Z

@bradkwadsworth-mw just to be clear, I do not feel comfortable with the current state of tests because we made a good amount of changes on the PR after you tested. So it would be great if you could do a final round of tests with the latest changes and update the PR description. 🙏

turkenf · 2023-07-20T04:57:29Z

FYI: Next release of provider-gcp is scheduled for Thu, 27 July.

Signed-off-by: Brad Wadsworth <[email protected]>

bradkwadsworth-mw · 2023-07-20T14:58:53Z

I updated the description and removed references to Access Policies because they ids were not being generated correctly.

turkenf

Thank you for your contribution @bradkwadsworth-mw, LGTM.

bradkwadsworth-mw requested review from ulucinar and sergenyalcin as code owners July 6, 2023 18:49

turkenf reviewed Jul 7, 2023

View reviewed changes

turkenf reviewed Jul 8, 2023

View reviewed changes

turkenf reviewed Jul 18, 2023

View reviewed changes

examples/accesscontextmanager/accesslevelcondition.yaml Outdated Show resolved Hide resolved

examples/accesscontextmanager/serviceperimeter.yaml Outdated Show resolved Hide resolved

Brad Wadsworth added 15 commits July 20, 2023 08:55

Add google_access_context_manager_service_perimeter_resource

611b646

added google_access_context_manager_access_policy

8557f5b

Signed-off-by: Brad Wadsworth <[email protected]>

added google_access_context_manager_access_level

e2af028

Signed-off-by: Brad Wadsworth <[email protected]>

added google_access_context_manager_access_level_condition

c4fb79d

add google_access_context_manager_access_policy_iam_member

9e019a1

added google_access_context_manager_service_perimeter

f417022

added google_access_context_manager_service_perimeter_resource

10c0561

testing resources

61a5468

removed refs

bafaac3

fixed examples

a99dedc

updated examples

c846c21

fixed example

4f835f0

fixed refs

9ed9a0c

fixed examples

6381612

removed reference to access policy

b943b9e

bradkwadsworth-mw force-pushed the feature/add-google_access_context_manager-resources branch from c7a2daa to b943b9e Compare July 20, 2023 14:57

fixed local-deploy test

4b6ec5d

turkenf approved these changes Jul 20, 2023

View reviewed changes

turkenf mentioned this pull request Jul 20, 2023

Moving accesscontextmanager (7) resources to v1beta1 version #120

Closed

7 tasks

turkenf merged commit 34eb383 into crossplane-contrib:main Jul 20, 2023
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/add google access context manager resources #331

Feature/add google access context manager resources #331

bradkwadsworth-mw commented Jul 6, 2023 •

edited by turkenf

Loading

jeanduplessis commented Jul 7, 2023

turkenf left a comment

turkenf left a comment

bradkwadsworth-mw commented Jul 18, 2023

turkenf commented Jul 19, 2023

turkenf commented Jul 19, 2023

turkenf commented Jul 20, 2023

bradkwadsworth-mw commented Jul 20, 2023

turkenf left a comment

Feature/add google access context manager resources #331

Feature/add google access context manager resources #331

Conversation

bradkwadsworth-mw commented Jul 6, 2023 • edited by turkenf Loading

Description of your changes

How has this code been tested

jeanduplessis commented Jul 7, 2023

turkenf left a comment

Choose a reason for hiding this comment

turkenf left a comment

Choose a reason for hiding this comment

bradkwadsworth-mw commented Jul 18, 2023

turkenf commented Jul 19, 2023

turkenf commented Jul 19, 2023

turkenf commented Jul 20, 2023

bradkwadsworth-mw commented Jul 20, 2023

turkenf left a comment

Choose a reason for hiding this comment

bradkwadsworth-mw commented Jul 6, 2023 •

edited by turkenf

Loading