feat(redis): add Redis Cluster support #623
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickard-von-essen
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
|
/test-examples="examples/redis/v1beta1/cluster.yaml" |
This adds support for google_redis_cluster Terraform resource, see https://registry.terraform.io/providers/hashicorp/google/5.39.1/docs/resources/redis_cluster Signed-off-by: Rickard von Essen <[email protected]>
rickard-von-essen
force-pushed
the
feature/redis-cluster
branch
from
5f5a53b
to
e293445
Compare
|
/test-examples="examples/redis/v1beta1/cluster.yaml" |
rickard-von-essen
force-pushed
the
feature/redis-cluster
branch
2 times, most recently
from
3bd57da
to
a8884e1
Compare
Signed-off-by: Rickard von Essen <[email protected]>
rickard-von-essen
force-pushed
the
feature/redis-cluster
branch
from
a8884e1
to
9ebbb41
Compare
|
@jeanduplessis Could I get a final (hopefully) /test-example... on this 🙏🏻 |
|
/test-examples="examples/redis/v1beta1/cluster.yaml" |
|
Fails because of missing prerequisite Service Connection Policy. Which I started on in #624 but Upjet fails to correctly generate a |
|
Depends on #624 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This adds support for
google_redis_clusterTerraform resource, see Terraform - Google - redis_cluster.Replaces #513
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary. N/AHow has this code been tested
I have tested, create, import, update, and delete of a Memorystore Redis Cluster. And also verified that the
AdditionalConnectionDetailsFnfunctions.One odd thing is that
examples-generated/redis/v1beta1/cluster.yamlcontains:But it has to be changed to:
Otherwise the apply fails.