Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for retry_delay_ms, max_retries, retryable_errors #81

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

lacroi-m-insta
Copy link
Contributor

@lacroi-m-insta lacroi-m-insta commented Jul 5, 2024

When a project secret is out of date and that you have a webhook resource the terraform provider spams github until rate limit. By adding the possibility to configure retry_delay_ms, max_retries and retryable_errors it is posisble to avoid this. I have tested this on my end with success by setting this:

{"owner":"lacroi-m-insta","token":"xxxx","write_delay_ms":60000,"read_delay_ms":60000,"retry_delay_ms":60000,"max_retries":1,"retryable_errors":[401]}

As the token of the matching secret.

These values are only available in the versions of TERRAFORM_PROVIDER_VERSION above 6.2.1

@AtzeDeVries
Copy link
Collaborator

AtzeDeVries commented Jul 30, 2024

@lacroi-m-insta I just merged #80

This creates a lot of merge conflicts. This pr also updates the provider to 6.2.2.

@lacroi-m-insta lacroi-m-insta changed the title feat: bump teraform provider version to 6.2.1 and add support for retry_delay_ms, max_retries, retryable_errors feat: add support for retry_delay_ms, max_retries, retryable_errors Aug 27, 2024
@lacroi-m-insta
Copy link
Contributor Author

@AtzeDeVries great it will make for a cleaner PR 😄 I've updated my repository it's ready now

@lacroi-m-insta
Copy link
Contributor Author

I didnt see this linting pipeline when testing. Refactored the code to fit the spec

@AtzeDeVries
Copy link
Collaborator

@lacroi-m-insta thanks for the contribution! will merge.

@AtzeDeVries AtzeDeVries merged commit afa3f3e into crossplane-contrib:main Sep 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants