Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard coded world IDs in code #7

Open
Inumedia opened this issue Jan 9, 2017 · 0 comments
Open

Hard coded world IDs in code #7

Inumedia opened this issue Jan 9, 2017 · 0 comments

Comments

@Inumedia
Copy link
Contributor

Inumedia commented Jan 9, 2017

$.getJSON("http://maplestory.io/api/server/3/market/legacy"

We should never be hard coding the world IDs like this in the code, the JavaScript should be independent from whatever state the user is in / what world they are looking at
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Inumedia