Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mmap thoughts #20

Open
crumblingstatue opened this issue Aug 16, 2022 · 0 comments
Open

mmap thoughts #20

crumblingstatue opened this issue Aug 16, 2022 · 0 comments
Labels
hard Things that are hard to implement properly, and might need considerable refactoring Open ended Issues that need lots of thinking and trying out different options before coming to a conclusion.

Comments

@crumblingstatue
Copy link
Owner

If it's possible to safely write back cowed regions: The changed regions must be written back exactly to avoid undefined behavior. So damage ranges should never cover more than they changed. No merging of damaged ranges with unchanged data inbetween. It should however be possible to merge ranges that are exactly next to each other, like when editing bytes one after another.

If it turns out it's necessary to copy changes to memory buffers separate from cow before saving, keep track of memory that would be needed, and warn user if memory needed would be too great to safely save.

@crumblingstatue crumblingstatue added hard Things that are hard to implement properly, and might need considerable refactoring Open ended Issues that need lots of thinking and trying out different options before coming to a conclusion. labels Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hard Things that are hard to implement properly, and might need considerable refactoring Open ended Issues that need lots of thinking and trying out different options before coming to a conclusion.
Projects
None yet
Development

No branches or pull requests

1 participant