Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: Support amount list on MsgSend & remove some Todos #280

Merged
merged 9 commits into from
Jun 28, 2021
Merged

Problem: Support amount list on MsgSend & remove some Todos #280

merged 9 commits into from
Jun 28, 2021

Conversation

cdc-Hitesh
Copy link
Contributor

Fixes #278

@codecov
Copy link

codecov bot commented Jun 16, 2021 •
edited
Loading

Codecov Report

Merging #280 (450ccc2) into tx-revamp-dev (b96ed43) will increase coverage by 7.39%.
The diff coverage is 98.25%.

Impacted file tree graph

@@                Coverage Diff                @@
##           tx-revamp-dev     #280      +/-   ##
=================================================
+ Coverage          89.34%   96.74%   +7.39%     
=================================================
  Files                101      118      +17     
  Lines               3613     5006    +1393     
  Branches             261      322      +61     
=================================================
+ Hits                3228     4843    +1615     
+ Misses               385      163     -222
Impacted Files Coverage Δ
lib/src/transaction/msg/bank/msgsend.spec.ts 100.00% <ø> (ø)
lib/src/transaction/msg/gov/ow.types.ts 94.73% <ø> (ø)
.../src/transaction/msg/staking/MsgBeginRedelegate.ts 91.89% <ø> (ø)
.../src/transaction/msg/staking/MsgCreateValidator.ts 94.23% <ø> (ø)
lib/src/utils/address.ts 80.00% <ø> (ø)
lib/src/utils/txDecoder.spec.ts 100.00% <ø> (ø)
...action/msg/gov/proposal/SoftwareUpgradeProposal.ts 87.87% <75.00%> (+37.87%) ⬆️
.../msg/gov/proposal/CancelSoftwareUpgradeProposal.ts 95.00% <80.00%> (+41.66%) ⬆️
lib/src/transaction/signable.ts 93.88% <81.81%> (-0.53%) ⬇️
...ion/msg/gov/proposal/CommunityPoolSpendProposal.ts 87.09% <84.61%> (ø)
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a3b227...450ccc2. Read the comment docs.

@cdc-Hitesh cdc-Hitesh linked an issue Jun 16, 2021 that may be closed by this pull request
Problem: Support amount list on MsgSend #278
Open
calvinlauyh
calvinlauyh reviewed Jun 28, 2021
View reviewed changes
Copy link
Contributor

@calvinlauyh calvinlauyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good to me! I notice most of the test cases and e2e test cases are covering single denom use cases. It would be good to cover multiple denoms.

We can create an new issue for this. Up to you @cdc-Hitesh

@calvinaco calvinaco merged commit dd7be09 into crypto-org-chain:tx-revamp-dev Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvinlauyh calvinlauyh calvinlauyh left review comments

@calvinaco calvinaco calvinaco approved these changes

@crypto-matto crypto-matto Awaiting requested review from crypto-matto crypto-matto is a code owner

@crypto-eddy crypto-eddy Awaiting requested review from crypto-eddy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: Support amount list on MsgSend
3 participants
@cdc-Hitesh @calvinlauyh @calvinaco