Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: skip signature verification when tx is retried in block-stm #564

Closed
yihuang opened this issue Jul 12, 2024 · 0 comments
Closed
Assignees

Comments

@yihuang
Copy link
Collaborator

yihuang commented Jul 12, 2024

Summary

When tx execution is conflicted in block-stm, it get retried, in each retry, it runs exact same logic, but we can actually cache some stateless computations, signature verification is the most significant one.

Problem Definition

We can't cache it in normal transient stores, because they are cleared for each tx execution for deterministic execution results.

Proposed Feature

Add a field to Context just for this.

@yihuang yihuang self-assigned this Jul 12, 2024
yihuang added a commit that referenced this issue Jul 15, 2024
… of same tx (#565)

* Problem: signature verification result not cache between incarnations of
same tx

Closes: #564

Solution:
- introduce incarnation cache that's shared between incarnations of the
  same tx

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* Update types/context.go

Signed-off-by: yihuang <[email protected]>

* Update types/context.go

Signed-off-by: yihuang <[email protected]>

* fix nil convert

---------

Signed-off-by: yihuang <[email protected]>
@yihuang yihuang closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant