Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: not supporting graceful close #1173

Closed
leejw51crypto opened this issue Sep 19, 2023 · 2 comments
Closed

Problem: not supporting graceful close #1173

leejw51crypto opened this issue Sep 19, 2023 · 2 comments
Assignees
@leejw51crypto

Comments

@leejw51crypto
Copy link
Contributor

sometimes, with ctrl-c, program not finishes gracefully
@leejw51crypto leejw51crypto self-assigned this Sep 19, 2023
@yihuang
Copy link
Collaborator

yihuang commented Sep 19, 2023

It's handled better in latest sdk, not integrated though.

leejw51crypto added a commit to leejw51crypto/cronos that referenced this issue Sep 19, 2023
@leejw51crypto
Problem: not supporting graceful close (fix crypto-org-chain#1173)
78e6423 
wait a little before shutdown
leejw51crypto added a commit to leejw51crypto/cronos that referenced this issue Sep 19, 2023
@leejw51crypto @mmsqe
Problem: not supporting graceful close (fix crypto-org-chain#1173)
3cc6447 
wait a little before shutdown

Update cmd/cronosd/main.go

thanks

Co-authored-by: mmsqe <[email protected]>
Signed-off-by: Jongwhan Lee <[email protected]>
leejw51crypto added a commit to leejw51crypto/cronos that referenced this issue Sep 19, 2023
@leejw51crypto
Problem: not supporting graceful close (fix crypto-org-chain#1173)
3fe56ad 
wait a little before shutdown

Update cmd/cronosd/main.go

thanks

Co-authored-by: mmsqe <[email protected]>
Signed-off-by: Jongwhan Lee <[email protected]>

change comment
leejw51crypto added a commit to leejw51crypto/cronos that referenced this issue Sep 20, 2023
@leejw51crypto
Problem: not supporting graceful close (fix crypto-org-chain#1173)
4c922a8 
wait a little before shutdown

Update cmd/cronosd/main.go

thanks

Co-authored-by: mmsqe <[email protected]>
Signed-off-by: Jongwhan Lee <[email protected]>

change comment

reduce waiting time
@leejw51crypto
Copy link
Contributor Author

with latest commit, cannot reproduce
close this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leejw51crypto leejw51crypto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yihuang @leejw51crypto