Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: dynamically limit maxHTLC #373

Open
thool2b3 opened this issue Jan 28, 2024 · 2 comments
Open

Feature Request: dynamically limit maxHTLC #373

thool2b3 opened this issue Jan 28, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@thool2b3
Copy link

To minimize failed HTLCs it would make sense to limit maxHTLC to channel balance plus channel reserve.
Please consider to add functionality to control maxHTLC dynamically based on channel balance.
Here is a proposal how it could be implemented:

  • maxHTLC set in Advanced Settings should still not be exceeded even when all liquidity is on my side
  • decrease maxHTLC dynamically down to zero when channel balance drops below a minimum value. maxHTLC could be calculated like this: channel reserve + minimum value + safety margin.
  • Channel reserve is given by LND. Parameters minimum value and safety margin should have a default value but could be changed individually.
  • I am not sure if it also makes sense to disable the channel when calculated maxHTLC drops to 0? Perhaps this could be optionally checked by the user.

Thank you for considering this feature request.

@BhaagBoseDK
Copy link
Collaborator

  • this should be elective policy (i.e. default = disabled)
  • to prevent excessive gossip this should be done once ever x hours (x can be configurable setting, suggested default 24 h)
  • Instead of using exact channel balance it could be nearest multiple of 2 or something like that.
  • disable/enable channel does impact reputation and causes confusion between peers so can be avoided.

@thool2b3
Copy link
Author

@BhaagBoseDK, thanks for your comments and the additions which I am thankful for.

@cryptosharks131 cryptosharks131 added the enhancement New feature or request label Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants