Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNIXSocket.new should accept Path in addition to String #15259

Open
BigBoyBarney opened this issue Dec 9, 2024 · 3 comments
Open

UNIXSocket.new should accept Path in addition to String #15259

BigBoyBarney opened this issue Dec 9, 2024 · 3 comments

Comments

@BigBoyBarney
Copy link
Contributor

Most methods that operate with filesystem paths accept both String and Path, like virtually everything in File.

UNIXSocket.new currently only takes String.

I assume this is because Path was added later and UNIXSocket wasn't changed to accommodate that. Would there be any problems with allowing Path too?

@RX14
Copy link
Contributor

RX14 commented Dec 9, 2024

I don't see any reason why not. If you see any other places, please bring those up too, it'd be nice to get as many as possible at once.

@BigBoyBarney
Copy link
Contributor Author

For now I've only encountered UNIXSocket#new and UNIXSocket#open.

@ysbaddaden
Copy link
Contributor

There's UNIXAddress too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants