feat: Create a config to override filesystem #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanhongit
added
enhancement
tanhongit
commented
Aug 18, 2024
| $configName = pathinfo($file, PATHINFO_FILENAME); | ||
| $configPath = $configDir.'/'.$file; | ||
|
|
||
| if (file_exists(config_path($configName.'.php'))) { |
There was a problem hiding this comment.
The updated code adds a check to see if the configuration file exists before merging. If it does, the new configuration is merged with the existing one using config()->set and array_merge. If the file doesn’t exist, it falls back to the original method of merging with mergeConfigFrom. This change enhances flexibility in handling configuration files.
tanhongit
deleted the
feature/Create-a-config-to-override-filesystem-#6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unit Testing
Operation check
Caution
Release Notes
Note
Additional Notes
Checklist