Method supportedValue should support !important property. #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LvChengbin
changed the title
LvChengbin
changed the title
kof
reviewed
Aug 23, 2020
| @@ -64,7 +64,7 @@ export default function supportedValue(property, value) { | |||
| // IE can even throw an error in some cases, for e.g. style.content = 'bar'. | |||
| try { | |||
| // Test value as it is. | |||
| el.style[property] = prefixedValue | |||
| el.style.setProperty(property, ...prefixedValue.split(/!(?=important$)/)) | |||
There was a problem hiding this comment.
- I think we don't need to pass important for the test at all, because the result for our tests should be the same no matter if there is important or not, we can get rid of spread operator here as well
- we need to do some micro benchmarking on esbench to see what's the fastest way to get rid of "important", I would guess str.replace will be much faster than doing the split
There was a problem hiding this comment.
My guess is this hsould be the fastest: .replace(/!important[\s]*$/, '') - I think supporting accidental whitespace at the end is a good idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
el.style.setProperty(property, value, priority)method instead of usingel.style[property] = valueto fix Method supportedValue should support !important property. #214 .