From 3a4486a208686dbfd84ab0b5ea8efcddf79e6b0e Mon Sep 17 00:00:00 2001 From: Oleg Isonen Date: Mon, 22 Mar 2021 13:07:40 +0100 Subject: [PATCH] typo --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ce8f28ef5..6db97ff9b 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -9,7 +9,7 @@ ## Expectations on changes -1. Please don't do code changes and move code around in the same PR, even if you are making code better. Make sure the reviewer can see just the changes which fix the problem. This can make your PR reviewable much more accessible in complex situations; otherwise, it might never get merged even if it is correct because it's impossible to review without reimplementing every change. +1. Please don't do code changes and move code around in the same PR, even if you are making code better. Make sure the reviewer can see just the changes which fix the problem. This can make your Code Review much more accessible in complex situations; otherwise, it might never get merged even if it is correct because it's impossible to review without reimplementing every change. 2. Often, submitting a failing test is more critical than the fix. Fixing the problem can be challenging and has many ways. Offering an excellent failing test is often 80% of the solution. 3. Please review your PR before submitting it as if you are the reviewer. This way, you show respect for the maintainer's time.