Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic css issue under a certain condition since version 10.9.1-alpha.1 #1630

Open
pei-wang opened this issue Aug 12, 2022 · 2 comments
Open

Comments

@pei-wang
Copy link

pei-wang commented Aug 12, 2022

Expected behavior:
work same as 10.9.1-alpha.0

Describe the bug:

when my component get re-rendered several times and it depends on another component which use dynamic function.
then the dynamic css class of the dependent component is missing.
From what I observer:
there are several prerequisites to trigger the issue.

  1. make some operations to cause components re-render
  2. having a nested element inside a dynamic css function.

Reproduction:

https://codesandbox.io/s/stupefied-minsky-lw7wxs

Versions (please complete the following information):

  • jss: 10.9.2
  • Browser [e.g. chrome, safari]: chrome
  • OS [e.g. Windows, macOS]: macOS
    encountered the issue since 10.9.1-alpha.1

Managing expectations:

Maintainers will not be fixing the problem you have unless they have it too, if you want it to get fixed:

  1. Submit a PR with a failing test
  2. Discuss a solution
  3. Implement it

You can also do the first step only and wait for someone else to work on a fix. Anything is much better than nothing.

@pei-wang
Copy link
Author

pei-wang commented Aug 14, 2022

caused by #1609. But I haven't seen any thing wrong in that PR.
I need to dive into to find more.
cc: @enisdenjo

@ynaut
Copy link

ynaut commented Aug 19, 2022

we've had a similar issue were dynamic rules would be removed after re-rendering React components.
We have the issue 10.9.1 but not in 10.9.0

Suspect it's related to the change in: #1604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants