Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jss-default-unit] use typed cssom values when possible #885

Closed
kof opened this issue Oct 12, 2018 · 1 comment
Closed

[jss-default-unit] use typed cssom values when possible #885

kof opened this issue Oct 12, 2018 · 1 comment
Labels
enhancement No kittens die if we don't do that. houdini 🎩

Comments

@kof
Copy link
Member

kof commented Oct 12, 2018

When user relies on default unit, we don't have to convert it to string, we can actually use cssom:

{
  margin: 10
}

should convert to

{
  margin: CSS.px(10)
}
@kof kof added enhancement No kittens die if we don't do that. houdini 🎩 labels Oct 12, 2018
@kof kof mentioned this issue Oct 12, 2018
Merged
This was referenced Oct 16, 2018
Closed
Merged
@kof
Copy link
Member Author

kof commented Oct 27, 2018

Foloow #795 for release updates.

@kof kof closed this as completed Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement No kittens die if we don't do that. houdini 🎩
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kof