[Bug] "defaultClassNamePrefix" set to undefined in production

[kof]

From @VintorezVS on October 23, 2018 6:0

Custom "classNamePrefix" concatenated with "defaultClassNamePrefix" in production gives "customprefix-undefinedXXX" class names.

...
const defaultClassNamePrefix = env === 'production' ? undefined : `${displayName}-`
...
let classNamePrefix = defaultClassNamePrefix
...
if (contextSheetOptions && contextSheetOptions.classNamePrefix) {
    classNamePrefix = contextSheetOptions.classNamePrefix + classNamePrefix
}
...

Copied from original issue: cssinjs/react-jss#304

[kof]

thanks for the report

[HenriBeck]

So instead of undefined let's just use an empty string or would this break something as well?

[kof]

I think it would be fine, wanna send a PR?

[HenriBeck]

This should already be fixed: 1e9ba74#diff-15944e28391ef80a3f4e34ea8a2193f4R99

[kof]

true, @VintorezVS subscribe #795 for notifications when v10 will be published

[airtonix]

Why is it even undefined in the first place? I mean, why in production is sheet.options.classNamePrefix not there? what do I change to make it be there.

We want the same classnames generated in dev and prod.

[micaste]

@airtonix my understanding is that classNamePrefix stays in production. What was undefined in PROD and has been replaced by an empty string is displayName.