Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step function support return a nil Context with error #592

Open
Milk-Tang opened this issue Dec 15, 2023 · 2 comments
Open

step function support return a nil Context with error #592

Milk-Tang opened this issue Dec 15, 2023 · 2 comments

Comments

@Milk-Tang
Copy link

πŸ‘“ What did you see?

panic occured while I return (nil, err) in the step function

βœ… What did you expect to see?

When I return a nil Context and non empty error, no panic error occurs

πŸ“¦ Which tool/library version are you using?

v0.12.6

πŸ”¬ How could we reproduce it?

Run this step

func StepError(ctx context.Context) (context.Context, err) {
    return nil, errors.New("step failed")
}
@o-brunofernandes
Copy link

Did you get an answer on this?

@Johnlon
Copy link
Member

Johnlon commented Oct 6, 2024

You do get an error IIRC, but it's pretty horrible error caused by a cast if I recall and the cause isn't at all obvious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants