Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡Pass in context to provide instead of using getContext #22

Open
runspired opened this issue Mar 27, 2024 · 0 comments
Open

💡Pass in context to provide instead of using getContext #22

runspired opened this issue Mar 27, 2024 · 0 comments

Comments

@runspired
Copy link

low(ish) priority

const context = getContext() as TestContext | undefined;

getContext as a pattern is one (of several) things that is preventing ember applications from running tests concurrently as it assumes only a single global test context exists at any one time.

Instead of assuming the global, we should prefer a passed in context.

@runspired runspired changed the title Pass in context to provide instead of using getContext 💡Pass in context to provide instead of using getContext Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant