diff --git a/retros/2024-09-22.md b/retros/2024-09-22.md new file mode 100644 index 0000000..52799a3 --- /dev/null +++ b/retros/2024-09-22.md @@ -0,0 +1,266 @@ +# Retrospective for `nodejs` from 2024-09-22 to 2024-09-29 + +Reporting on 42 Issues from 32 authors, 58 Pull Requests from 31 authors, and 11 Discussions from 10 authors. + + +### reliability + +#### Open Issues + +- CI Reliability 2024-09-29 ([#981](https://github.com/nodejs/reliability/issues/981)) +- CI Reliability 2024-09-28 ([#980](https://github.com/nodejs/reliability/issues/980)) +- CI Reliability 2024-09-27 ([#979](https://github.com/nodejs/reliability/issues/979)) +- CI Reliability 2024-09-26 ([#978](https://github.com/nodejs/reliability/issues/978)) +- CI Reliability 2024-09-25 ([#977](https://github.com/nodejs/reliability/issues/977)) + +### node + +#### Open Issues + +- parallel/test-runner-coverage is flaky ([#55154](https://github.com/nodejs/node/issues/55154)) +- Streams: finished Change in behavoir between 22.2.0 and 22.9.0. Throws Exception (Unhandled Rejection) ([#55152](https://github.com/nodejs/node/issues/55152)) +- Assertion failed: `args[1]->IsUint32()` when slicing Blob with non-integer parameters ([#55139](https://github.com/nodejs/node/issues/55139)) +- `structuredClone` Serializing a non-serializable platform object succeeds ([#55120](https://github.com/nodejs/node/issues/55120)) +- UV_USE_IO_URING does not update file handle position ([#55113](https://github.com/nodejs/node/issues/55113)) +- [22.9.0] `util.getCallSite()` doesn't report original line number for TS files ([#55109](https://github.com/nodejs/node/issues/55109)) +- `sourcesContent` not correctly handled in coverage reporter with `--enable-source-maps` ([#55106](https://github.com/nodejs/node/issues/55106)) + +#### Open Pull Requests + +- deps: patch V8 to 12.9.202.24 ([#55161](https://github.com/nodejs/node/pull/55161)) +- tools: update gyp-next to 0.18.2 ([#55160](https://github.com/nodejs/node/pull/55160)) +- benchmark: add no-warnings to process.has bench ([#55159](https://github.com/nodejs/node/pull/55159)) +- benchmark: add --runs support to run.js ([#55158](https://github.com/nodejs/node/pull/55158)) +- test: add resource to internal module stat test ([#55157](https://github.com/nodejs/node/pull/55157)) +- src: remove icu based `ToASCII` and `ToUnicode` ([#55156](https://github.com/nodejs/node/pull/55156)) +- src: modernize likely/unlikely hints ([#55155](https://github.com/nodejs/node/pull/55155)) +- stream: handle undefined chunks correctly in decode stream ([#55153](https://github.com/nodejs/node/pull/55153)) +- test: update wpt test for encoding ([#55151](https://github.com/nodejs/node/pull/55151)) +- lib: fix module print timing when specifier includes `"` ([#55150](https://github.com/nodejs/node/pull/55150)) +- fs: acknowledge `signal` option in `filehandle.createReadStream()` ([#55148](https://github.com/nodejs/node/pull/55148)) +- doc: fix `events.once()` example with `AbortSignal` ([#55144](https://github.com/nodejs/node/pull/55144)) +- test_runner: avoid spread operator on arrays ([#55143](https://github.com/nodejs/node/pull/55143)) +- test: remove unnecessary `await` in test-watch-mode ([#55142](https://github.com/nodejs/node/pull/55142)) +- buffer: coerce extrema to int in `blob.slice` ([#55141](https://github.com/nodejs/node/pull/55141)) +- build: describe the fix for compiling android node.js on an x86_64 host ([#55133](https://github.com/nodejs/node/pull/55133)) +- test: add `escapePOSIXShell` util ([#55125](https://github.com/nodejs/node/pull/55125)) +- test: move coverage source map tests to new file ([#55123](https://github.com/nodejs/node/pull/55123)) +- src: fixup Error.stackTraceLimit during snapshot building ([#55121](https://github.com/nodejs/node/pull/55121)) +- diagnostics_channel: fix unsubscribe during publish ([#55116](https://github.com/nodejs/node/pull/55116)) +- deps: V8: backport 0d5d6e71bbb0 ([#55115](https://github.com/nodejs/node/pull/55115)) +- deps: update libuv to 1.49.0 ([#55114](https://github.com/nodejs/node/pull/55114)) + +#### Open Discussions + +- Shouldn't default mode for flush be true for writeFile and similar methods? ([#55140](https://github.com/orgs/nodejs/discussions/55140)) +- deprecate unscoped packages ([#55128](https://github.com/orgs/nodejs/discussions/55128)) +- Unable to add CRL to https request ([#55105](https://github.com/orgs/nodejs/discussions/55105)) +- How Node.js actually responds to request in callbacks? ([#55074](https://github.com/orgs/nodejs/discussions/55074)) +- add pty to nodejs ([#54150](https://github.com/orgs/nodejs/discussions/54150)) + +#### Merged Pull Requests + +- doc: remove random horizontal separators in `process.md` ([#55149](https://github.com/nodejs/node/pull/55149)) +- buffer: correctly apply prototype to cloned `File` / `Blob` ([#55138](https://github.com/nodejs/node/pull/55138)) +- doc: add missing `:` to `run()`'s `globPatterns` ([#55135](https://github.com/nodejs/node/pull/55135)) +- doc: add esm examples to `node:net` ([#55134](https://github.com/nodejs/node/pull/55134)) +- doc: put --env-file-if-exists=config right under --env-file=config ([#55131](https://github.com/nodejs/node/pull/55131)) +- test_runner: support custom node options in `run()` ([#55126](https://github.com/nodejs/node/pull/55126)) +- tools: only check teams on the default branch ([#55124](https://github.com/nodejs/node/pull/55124)) +- stream: treat null asyncIterator as undefined ([#55119](https://github.com/nodejs/node/pull/55119)) +- doc: fix the require resolve algorithm in modules.md ([#55117](https://github.com/nodejs/node/pull/55117)) +- doc: move the YAML changes element regarding to https://github.com/nodejs/node/pull/54194 ([#55112](https://github.com/nodejs/node/pull/55112)) +- doc: remove outdated https import reference ([#55111](https://github.com/nodejs/node/pull/55111)) +- src: move more key handling to ncrypto ([#55108](https://github.com/nodejs/node/pull/55108)) + +#### Closed Issues + +- Javascript error ([#55147](https://github.com/nodejs/node/issues/55147)) +- Regression in 22.7+ causing malloc: Incorrect checksum for freed object ([#55145](https://github.com/nodejs/node/issues/55145)) +- Project ([#55137](https://github.com/nodejs/node/issues/55137)) +- بروجكت ([#55136](https://github.com/nodejs/node/issues/55136)) +- Set iteration causes unexpected infinite loop ([#55132](https://github.com/nodejs/node/issues/55132)) +- Error on npx gitignore when appdata/npm folder is missing ([#55130](https://github.com/nodejs/node/issues/55130)) +- `--env-file-if-exists` is in the wrong spot in the docs ([#55129](https://github.com/nodejs/node/issues/55129)) +- CPUが高い ([#55127](https://github.com/nodejs/node/issues/55127)) +- `File` is not serializable ([#55122](https://github.com/nodejs/node/issues/55122)) +- Environment file option matches on substring (--env-file) ([#55118](https://github.com/nodejs/node/issues/55118)) +- Request for a synchronous variant of node:test.test() method ([#55107](https://github.com/nodejs/node/issues/55107)) + +#### Closed Pull Requests + +- test_runner: consider --enable-source-maps option in coverage report ([#55146](https://github.com/nodejs/node/pull/55146)) +- test: update test-crypto-aes-wrap to use node:test ([#55110](https://github.com/nodejs/node/pull/55110)) +- src: track BaseObjects with an efficient list ([#55104](https://github.com/nodejs/node/pull/55104)) + +### corepack + +#### Closed Issues + +- “Error: getaddrinfo EAI_AGAIN registry.npmmirror.com” on docker build ([#564](https://github.com/nodejs/corepack/issues/564)) + +### nodejs.org + +#### Open Issues + +- Tabs off of https://nodejs.org/en/download/package-manager/all all 404 ([#7062](https://github.com/nodejs/nodejs.org/issues/7062)) +- "Learn about Node.js Releases" refers to a non-existent page ([#7060](https://github.com/nodejs/nodejs.org/issues/7060)) + +#### Open Pull Requests + +- Fix broken link to past releases ([#7061](https://github.com/nodejs/nodejs.org/pull/7061)) + +#### Open Discussions + +- question about /learn content ([#7028](https://github.com/nodejs/nodejs.org/discussions/7028)) + +#### Closed Pull Requests + +- Remove jargon from april-2024-security-releases.md ([#7059](https://github.com/nodejs/nodejs.org/pull/7059)) + +### security-wg + +#### Open Issues + +- Script execution control on Linux ([#1388](https://github.com/nodejs/security-wg/issues/1388)) + +#### Merged Pull Requests + +- update: cleanup repository ([#1387](https://github.com/nodejs/security-wg/pull/1387)) +- doc: add meeting note 2024-09-26 ([#1386](https://github.com/nodejs/security-wg/pull/1386)) +- OpenSSF Scorecard Report Updated ([#1385](https://github.com/nodejs/security-wg/pull/1385)) + +#### Closed Issues + +- OpenSSF Scorecard Report Updated! ([#1384](https://github.com/nodejs/security-wg/issues/1384)) + +### node-gyp + +#### Open Issues + +- SyntaxError from `import os` in `gyp_main.py` ([#3073](https://github.com/nodejs/node-gyp/issues/3073)) +- Use clang-cl for Windows ([#3072](https://github.com/nodejs/node-gyp/issues/3072)) + +### undici + +#### Open Issues + +- Trailing slash on origin causes interceptors to not match ([#3649](https://github.com/nodejs/undici/issues/3649)) +- Pool distributes load unevenly across connections. ([#3648](https://github.com/nodejs/undici/issues/3648)) +- AbortController/AbortSignal memory leak ([#3647](https://github.com/nodejs/undici/issues/3647)) +- dns tests fail out of the box ([#3646](https://github.com/nodejs/undici/issues/3646)) +- Request signal isn't aborted after garbage collection ([#3644](https://github.com/nodejs/undici/issues/3644)) + +#### Open Pull Requests + +- chore: integrate consume functions into BodyReadable ([#3650](https://github.com/nodejs/undici/pull/3650)) +- chore: remove redundant async in readable.js ([#3643](https://github.com/nodejs/undici/pull/3643)) + +#### Open Discussions + +- Backporting of PRs ([#3526](https://github.com/nodejs/undici/discussions/3526)) +- Does undici take care of consuming the response body if throwOnError: true? ([#3440](https://github.com/nodejs/undici/discussions/3440)) +- What's the best way to reset the MockPool between tests? ([#3619](https://github.com/nodejs/undici/discussions/3619)) +- HTTP/2 client inside HTTP/1.1 proxy connection ([#3613](https://github.com/nodejs/undici/discussions/3613)) + +#### Merged Pull Requests + +- prefer fail over close the websocket connection in error cases ([#3651](https://github.com/nodejs/undici/pull/3651)) +- export WebSocketStream, add docs and types ([#3645](https://github.com/nodejs/undici/pull/3645)) + +#### Closed Issues + +- > try to change Response to undici.Response lik this function req(url: string): Promise { return undici.fetch(url) } ([#3642](https://github.com/nodejs/undici/issues/3642)) + +### jenkins-alerts + +#### Closed Issues + +- test-orka-macos11-x64-2 has low disk space ([#2884](https://github.com/nodejs/jenkins-alerts/issues/2884)) +- test-softlayer-debian12-x64-1 has low disk space ([#2883](https://github.com/nodejs/jenkins-alerts/issues/2883)) + +### build + +#### Open Issues + +- release-macstadium-macos11.0-arm64-1 "No space left on device" ([#3917](https://github.com/nodejs/build/issues/3917)) + +#### Open Pull Requests + +- ansible: add test-digitalocean-freebsd13-x64-1 ([#3918](https://github.com/nodejs/build/pull/3918)) + +### tap2junit + +#### Open Issues + +- Tests fail because of non-deterministic floating-point precision ([#62](https://github.com/nodejs/tap2junit/issues/62)) + +#### Open Pull Requests + +- Fix XML comparison, compare time within 1e-6 seconds ([#63](https://github.com/nodejs/tap2junit/pull/63)) + +### nodejs-dist-indexer + +#### Open Issues + +- Add SWC ahd SQLite versions to the dist-indexer ([#33](https://github.com/nodejs/nodejs-dist-indexer/issues/33)) + +### release-cloudflare-worker + +#### Open Issues + +- Error: get: We encountered an internal error. Please try again. (10001) ([#141](https://github.com/nodejs/release-cloudflare-worker/issues/141)) + +### nodejs-news-feeder + +#### Open Pull Requests + +- Feed Updated 🍿 ([#105](https://github.com/nodejs/nodejs-news-feeder/pull/105)) + +### TSC + +#### Merged Pull Requests + +- fix(votes): typo in `closeVote.yml` ([#1624](https://github.com/nodejs/TSC/pull/1624)) + +### node-core-utils + +#### Open Pull Requests + +- chore: update dependencies ([#860](https://github.com/nodejs/node-core-utils/pull/860)) +- chore(main): release 5.5.2 ([#859](https://github.com/nodejs/node-core-utils/pull/859)) + +### node-addon-api + +#### Open Pull Requests + +- src: enable type cast checks in tests ([#1581](https://github.com/nodejs/node-addon-api/pull/1581)) + +### import-in-the-middle + +#### Open Pull Requests + +- fix: do nothing if target does not exist in getters map ([#155](https://github.com/nodejs/import-in-the-middle/pull/155)) + +#### Merged Pull Requests + +- chore: release v1.11.1 ([#154](https://github.com/nodejs/import-in-the-middle/pull/154)) +- fix: Support Hooking multiple times ([#153](https://github.com/nodejs/import-in-the-middle/pull/153)) + +### nan + +#### Open Pull Requests + +- Support for node version 20.17.0 ([#976](https://github.com/nodejs/nan/pull/976)) + +### admin + +#### Closed Pull Requests + +- doc: use `[!NOTE]` syntax in CoC ([#920](https://github.com/nodejs/admin/pull/920)) + +### single-executable + +#### Open Discussions + +- Layout for co-existing SEA resources ([#58](https://github.com/nodejs/single-executable/discussions/58)) \ No newline at end of file