Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about angle field’s loss function #36

Open
KunningZheng opened this issue Apr 17, 2024 · 1 comment
Open

Question about angle field’s loss function #36

KunningZheng opened this issue Apr 17, 2024 · 1 comment

Comments

@KunningZheng
Copy link

Hello, thank you for your work.
I tried drawing the plot of the angle field’s loss function with a fixed groundtruth A and found the following problem. I am wondering if I have misunderstood something in the paper.
cf1f6d4de8db797744e01b9a2746623

@rpautrat
Copy link
Member

Hi, I think that you are correct. The prediction in your example will converge to 0 and stay stuck there, so the loss is not optimal indeed.

I think that the second part of the loss was added at a time when the predicted angle was in [0, 2pi], but this is not the case anymore. So changing the loss directly to ||\hat{A} - A|| should work better. Thank you very much for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants