Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

train => disk +lg #72

Open
vampire1204 opened this issue Mar 21, 2024 · 1 comment
Open

train => disk +lg #72

vampire1204 opened this issue Mar 21, 2024 · 1 comment

Comments

@vampire1204
Copy link

vampire1204 commented Mar 21, 2024

Thanks for your impressive work!
I find something maybe wrong while I train mine custom datasets

in disk_kornia.py -> _forward -> for .... ->
image[: min(image.shape[0], i + chunk)] (here)

'''
for i in range(0, image.shape[0], chunk):
if self.conf.dense_outputs:
features, d_descriptors = self._get_dense_outputs(
image[: min(image.shape[0], i + chunk)]
)
dense_descriptors.append(d_descriptors)
else:
features = self.model(
image[: min(image.shape[0], i + chunk)],
n=self.conf.max_num_keypoints,
window_size=self.conf.nms_window_size,
score_threshold=self.conf.detection_threshold,
pad_if_not_divisible=self.conf.pad_if_not_divisible,
)
keypoints += [f.keypoints for f in features]
scores += [f.detection_scores for f in features]
descriptors += [f.descriptors for f in features]
del features
'''

I think it's range maybe wrong. I don't know if you agree? Thanks again

@vampire1204
Copy link
Author

I used image[i: min(image.shape[0], i + chunk)]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant