Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bring back --up flag #255

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

marco-m
Copy link
Contributor

@marco-m marco-m commented Dec 16, 2024

Desired Outcome

Fix #254 (flag --up is not working any more).

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In
particular, consider:

  • What's changed? Why were these changes made?

Added back the handling of --up flag, which has been removed by mistake (I think).

  • How should the reviewer approach this PR, especially if manual tests are required?

Best reviewed commit-per-commit, considering the commit messages.

No manual tests are required; the PR adds an integration test to protect from this regression. See the comments I added in #254 for details.

Connected Issue/Story

Resolves #254

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

This is the original test when I introduced the --up flag
This time we add an integration test, to make it sure that a test will catch it.
@SpectreVert
Copy link

LGTM. The integration test is a good addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

--up is broken: open secrets.yml: no such file or directory
2 participants