Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: prevent orphaned containers testing locally #1225

Merged

Conversation

MikeMcC399
Copy link
Collaborator

Issue

When following the instructions in CONTRIBUTING > Building locally, shown condensed below, using Docker Desktop 4.33.0 and above, repeating the docker compose run command leads to a warning "Found orphan containers"

Instructions

cd factory
docker compose build factory
docker compose build included
cd test-project
set -a && . ../.env && set +a
docker compose run test-factory-all-included

Warning

WARN[0000] Found orphan containers ([test-project-test-factory-all-included-run-fbb451183daf]) for this project. If you removed or renamed this service in your compose file, you can run this command with the --remove-orphans flag to clean it up.

Change

In CONTRIBUTING > Building locally change the instruction to the following, using the option --rm (Automatically remove the container when it exits), to avoid leaving an orphaned container behind:

docker compose run --rm test-factory-all-included

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review October 9, 2024 13:31
@MikeMcC399 MikeMcC399 self-assigned this Oct 9, 2024
@jennifer-shehane jennifer-shehane merged commit 727ea0b into cypress-io:master Oct 9, 2024
33 checks passed
@MikeMcC399 MikeMcC399 deleted the remove-test-container branch October 9, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants