Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Remove AWS secrets manager in local tests #178

Open
tyrannosaurus-becks opened this issue Aug 4, 2020 · 0 comments
Open

Remove AWS secrets manager in local tests #178

tyrannosaurus-becks opened this issue Aug 4, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@tyrannosaurus-becks
Copy link
Contributor

When running make test locally, it fails before running the tests with:

An error occurred (AccessDeniedException) when calling the CreateSecret operation: User: arn:aws:iam::733164497221:user/becca is not authorized to perform: secretsmanager:CreateSecret on resource: 
<redacted>

This occurs because I don't have sufficient privileges to use AWS secrets manager on my local user account.

One option for fixing it would be that I could just add permissions. However, secrets do have a cost associated with them, and we should only be automating running tests that use free resources. Also, we wouldn't want all contributors to have to add CreateSecret permissions to their local account in order to successfully run tests.

Can we instead disable these tests locally, but leave them enabled remotely?

@tyrannosaurus-becks tyrannosaurus-becks added the bug Something isn't working label Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants