keyboardShouldPersistTaps={true}

[arunkumarrmrj]

Issue Description

Steps to Reproduce / Code Snippets

Load a basic app with react-native-modal-picker and react-native 0.42

Expected Results

no warning

Additional Information

React Native version: ^0.42.0
react-native-modal-picker version: ^0.0.16
Platform(s) (iOS, Android, or both?): iOS

[xchau]

Not an ideal solution but I rolled back RN to v.0.39.2.

[eiosca]

It's just a warning about function deprecated prop. I create a PR for that. #49

[jawinn]

It would be nice to get this rolled into the code, to remove the warning for those of us on React Native 0.42.

Does this deprecated prop currently cause any issues? True and false are still listed on the docs, but are listed as deprecated:
http://facebook.github.io/react-native/releases/0.42/docs/scrollview.html#keyboardshouldpersisttaps

[arturnista]

@jawinn Besides a Warning, no issues

[eubotas]

change the index.js in react-native-modal-picker line 134 :
ScrollView keyboardShouldPersistTaps="always"

[peacechen]

This RN deprecation was done quite badly IMHO. If keyboardShouldPersistTaps is changed from a bool to a string, it will resolve the warning in RN 0.4x. However that change will break RN 0.3x. RN should have supported both by internally checking the type and act accordingly.

The app code will now have to detect which version of RN is running and pass different values.