Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broke with react 16.0.0 @ React.PropTypes move to seperate package #70

Open
skathayat opened this issue Oct 6, 2017 · 1 comment
Open

Comments

@skathayat
Copy link

React v. 16.0.0 comes up with separate 'prop-types module. Having said that it is not included in React itself. That means when react-native-modal-picker is used with react v16.0.0, following error appears

"Cannot read property oneOfType" of undefined.

Any fix for this?

I think the solution will be importing PropType from 'prop-types' instead of 'react

Currently in react-native-modal-picker - import React, { Component, PropTypes } from 'react';
Should be - import PropTypes from 'prop-types'

@mikaello
Copy link

mikaello commented Oct 6, 2017

Check out react-native-modal-selector, a (official) fork of this repo that have implemented a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants