Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] adopt comment-api #128

Open
heartacker opened this issue Jan 26, 2022 · 3 comments
Open

[feature] adopt comment-api #128

heartacker opened this issue Jan 26, 2022 · 3 comments

Comments

@heartacker
Copy link

🧩 Feature

adopt comment api

Description

https://code.visualstudio.com/updates/v1_35#_comments-api

https://github.com/microsoft/vscode-extension-samples/tree/main/comment-sample

A clear and concise description of the feature
@keesj-exset
Copy link

look nice and it also looks like a selection of multiple lines can be made. For our review purposes marking "reviewed" areas is important

@croesnick
Copy link
Contributor

I very much like that. We also stumbled upon this API in the last couple of days. It looks very nice and is used by other plugins as well (Atlassian plugin for instance).

I see two topics to be tackled, though, before starting any implementation:

  • How to integrate all the information that can currently be entered in the webview into this inline view? (name, description, category, priority)
  • How should the data model look like when multiple comments are added?

@d-koppenhagen
Copy link
Owner

Ich think this will be a quite heavy breaking change. As far as I have seen, there is no possibility to provide a custom layout within this comment box.

Another Idea could be to have this in addition for making fast comments, which can be edited in the current editor afterwards and assigned to categories etc.

Multiple comments could be handled in the current data structure by es special escape sequence. But maybe it would be the best to refactor everything including the data model and provide a completely new version / plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants