Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InterpBlock and InterpExprs #8

Open
sonmarcho opened this issue Aug 19, 2022 · 0 comments
Open

Update InterpBlock and InterpExprs #8

sonmarcho opened this issue Aug 19, 2022 · 0 comments

Comments

@sonmarcho
Copy link
Contributor

Following a chat: we should update InterpBlock to use InterpExprs, and update InterpExprs to return a (seq<Value>, InterpResult<()>).

The sequence of values returned by InterpExprs would contain the values computed for all the expressions which successfully evaluated:

  • if the result is Success its length would be |es|
  • if the result is Fail its length would be < |es|

This would allow us to check those values afterwards. For instance, even if some expression failed to evaluate, we could check that all the expressions before evaluated to (), and return the proper error if it was not the case. This should also work well once we add exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant