Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null safety required for Firebase AppInstanceId retrieval #1

Open
pavitrapandey opened this issue Nov 29, 2024 · 1 comment
Open

Null safety required for Firebase AppInstanceId retrieval #1

pavitrapandey opened this issue Nov 29, 2024 · 1 comment

Comments

@pavitrapandey
Copy link

The code in LauncherActivity uses FirebaseAnalytics.getAppInstanceId() without checking if task.getResult() is null. If the result is null, adding it to mQueryParams could lead to a crash or incorrect behavior. Adding a null check would make this code more robust.

@idoshamun
Copy link
Member

Hi @pavitrapandey,

Feel free to contribute this fix. Thanks a lot for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants