Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Wellknown endpoints completely overwrite the authWellknownEndpoints configuration #1983

Open
dard0r opened this issue Jul 15, 2024 · 2 comments

Comments

@dard0r
Copy link
Contributor

dard0r commented Jul 15, 2024

Version

18.0.1

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

At the start of the login flow, the endpoints from the well-known configuration overwrite the `authWellknownEndpoints` object.

Steps to reproduce the behavior

No response

A clear and concise description of what you expected to happen.

The sessionStorage endpoints should be a merge of the well-known and the `authWellknownEndpoints` configuration object.

Additional context

This could be caused by the changes merged with PR #1922.

@amiram
Copy link

amiram commented Sep 30, 2024

Happened to me also in version 17 and 18. Something is overriding the authWellknownEndpoints in the storage with an empty object. Version 16 is ok.

@patrikbjork
Copy link

These lines from 7b1577b:

map((mappedWellKnownEndpoints) => ({
  ...mappedWellKnownEndpoints,
  ...authWellknownEndpoints,
}))

Seems to cause the newly fetched mappedWellKnownEndpoints to be overridden by the stored authWellknownEndpoints, so if the endpoints are changed on the server it doesn't get updated in the configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants