Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zarrbargo design document #2003

Closed
yarikoptic opened this issue Aug 12, 2024 · 3 comments
Closed

Zarrbargo design document #2003

yarikoptic opened this issue Aug 12, 2024 · 3 comments
Assignees
Labels
design-doc Involves creating or discussing a design document embargo Issues around embargo functionality

Comments

@yarikoptic
Copy link
Member

As it has been on our on our list of targets and we agreed that it is orthogonal (at least largely), it would be great to hear your current ideas on how it could/should be implemented. I think a design document PR would be great to see what you are thinking about.

@waxlamp waxlamp added the design-doc Involves creating or discussing a design document label Aug 24, 2024
@aaronkanzer
Copy link
Member

@jjnesbitt @waxlamp

Here is a rough draft Design Doc that @kabilar and I used for our initial first pass at using AWS Cloudfront presigned cookies as a method of fast access to zarr assets in S3

https://github.com/lincbrain/linc-archive/pull/111/files

Here is also our main PR that included the API endpoint that issued the cookies to the user
https://github.com/lincbrain/linc-archive/pull/126/files

Let me know if you'd like to take a first pass at the design doc, meet prior, or have me take a peek -- happy to work with whatever your preference might be.

Cc @yarikoptic @satra

@yarikoptic
Copy link
Member Author

just a note: I think such a document among tech details should describe the need , or provision refactoring to remove the need for EmbargoedZarrArchive which survived the

  • 9fc81a4 : "Rip out embargoed models"

I feel that like for AssetBlob it should be sufficient to just define embargoed bool attribute as long as we keep embargoed zarrs in the same bucket/location as public zarrs.

@yarikoptic yarikoptic added the embargo Issues around embargo functionality label Oct 9, 2024
@jjnesbitt
Copy link
Member

Superseded by #2069.

"Zarrbargo" is really just the extension of the embargo re-design to include zarrs, which doesn't really entail a large overarching change. That PR description contains all the information that would be present in a design doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-doc Involves creating or discussing a design document embargo Issues around embargo functionality
Projects
None yet
Development

No branches or pull requests

4 participants