Plain text organization invite URL is broken #5097
Labels
bug
Something isn't working
Comments
BlackDex
added a commit
to BlackDex/vaultwarden
that referenced
this issue
Oct 18, 2024
Ever since we changed to pass the full url as a template value handlebars now html-encodes this.
This causes issues with the plain/text mails, but it also could potentially cause issues with the text/html templates.
This PR encloses the template values inside triple braces `{{{ }}}` which prevents html-encoding.
Since the URL is generated via the `url` crate the values are percent-encoded anyway.
Fixes dani-garcia#5097
Signed-off-by: BlackDex <[email protected]>
|
Indeed, and resolved via #5100 |
dani-garcia
pushed a commit
that referenced
this issue
Oct 18, 2024
Ever since we changed to pass the full url as a template value handlebars now html-encodes this.
This causes issues with the plain/text mails, but it also could potentially cause issues with the text/html templates.
This PR encloses the template values inside triple braces `{{{ }}}` which prevents html-encoding.
Since the URL is generated via the `url` crate the values are percent-encoded anyway.
Fixes #5097
Signed-off-by: BlackDex <[email protected]>
|
Thanks for the quick fix, appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Vaultwarden Support String
Admin mode is not enabled, should not be relevant
Vaultwarden Build Version
1.32.1
Deployment method
OS Package (apt, yum/dnf, pacman, apk, nix, ...)
Custom deployment method
No response
Reverse Proxy
nginx 1.22.1
Host/Server Operating System
Linux
Operating System Version
No response
Clients
Web Vault
Client Version
No response
Steps To Reproduce
Expected Result
The URL should be properly formed in both HTML and plain text variant, like
https://vaultwarden.example.org/#/accept-organization/?email=test%40example.org&organizationName=test+orga&organizationId=<>&organizationUserId=<>&token=<>Actual Result
The URL is only correctly formed in the HTML variant, in the plain text variant it reads
https://vaultwarden.example.org/#/accept-organization/?email=test%40example.org&organizationName=test+orga&organizationId=<>&organizationUserId=<>&token=<>And when you click this link you get "Unable to accept invitation. Ask an organization admin to send a new invitation."
Logs
No response
Screenshots or Videos
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: