Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatumConverter invokes autoload #162

Open
ForbiddenEra opened this issue Sep 24, 2019 · 2 comments
Open

DatumConverter invokes autoload #162

ForbiddenEra opened this issue Sep 24, 2019 · 2 comments

Comments

@ForbiddenEra
Copy link

rdb/DatumConverter.php:37 should be:
if (is_subclass_of($val, "\\r\\Query", FALSE) && !is_subclass_of($val, '\r\Datum\Datum', FALSE)) {

unless I'm doing something wrong, trying to insert anything but a true/false value results in autoloader invoking and causing an error.

adding this fixed it.
@Geekimo
Copy link

Geekimo commented Sep 24, 2019

#148 solved this behavior. It may now need some update since the owner hasn't been there for long and the pull hasn't been merged.

@c01nd01r
Copy link

c01nd01r commented Dec 5, 2019 •
edited
Loading

I discovered similar behavior.
@danielmewes May be possible to review and merge PR #148 ?

c01nd01r added a commit to armax-ru/php-rql that referenced this issue Dec 5, 2019
@c01nd01r
[fix] See danielmewes#162
1ed419a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Geekimo @c01nd01r @ForbiddenEra