Skip to content

Latest commit

 

History

History
19 lines (18 loc) · 611 Bytes

PULL_REQUEST_TEMPLATE.md

File metadata and controls

19 lines (18 loc) · 611 Bytes

Story Link:

Code Review Process Checklist

  • Read the story
  • Will the pull request merge into the correct branch?
  • Pull the branch
    • Does the app run?
    • Does the app meet conditions of satisfaction?
    • Are there 0 warnings?
  • Run ALL the unit tests (CMD+U)
    • Do they all pass?
  • Go through the changes:
    • Do they check for nils and nulls?
    • Do they account for potential crashes?
    • Does it conform to the architecture?
    • Are they inline with the coding standards?
    • Do they make sense?
    • Are they clean?
    • Easily readable?