Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when delete a common/space - it still shows up until refresh #1799

Closed
NoamQA opened this issue Jul 5, 2023 · 8 comments · Fixed by #1901
Closed

when delete a common/space - it still shows up until refresh #1799

NoamQA opened this issue Jul 5, 2023 · 8 comments · Fixed by #1901
Assignees
Labels
bug Something isn't working high priority

Comments

@NoamQA
Copy link
Collaborator

NoamQA commented Jul 5, 2023

should automatically refresh
if its a space - load the parent common
if its a common- open another one

(notion ticket here)

@NoamQA NoamQA added the bug Something isn't working label Jul 5, 2023
@elatif2020 elatif2020 removed their assignment Jul 21, 2023
@andreymikhadyuk andreymikhadyuk self-assigned this Jul 24, 2023
andreymikhadyuk added a commit that referenced this issue Jul 26, 2023
…-redirect

when delete a common/space - it still shows up until refresh #1799
@NoamQA
Copy link
Collaborator Author

NoamQA commented Jul 27, 2023

@andreymikhadyuk
❌ the delete doesnt work properly...
when i vote for in the delete proposal of a common it is shown as rejected
image

and when i vote for a proposal it is shown as passing
but remains in the bread crump
and after refresh shown as rejected

image

@NoamQA NoamQA reopened this Jul 27, 2023
@NoamQA
Copy link
Collaborator Author

NoamQA commented Jul 27, 2023

@andreymikhadyuk
could it be another issue?
also happens in prod
update me if to open a different ticket for it

@andreymikhadyuk
Copy link
Collaborator

@NoamQA not sure, for me it worked fine.

@andreymikhadyuk
Copy link
Collaborator

@NoamQA When it is showing Passing it should still be in the breadcrumbs.

@NoamQA
Copy link
Collaborator Author

NoamQA commented Jul 27, 2023

@andreymikhadyuk
try to delete a space that you are the only member in
a proposal for a delete is created
if you vote for it
the space should disappear from the breadcrumbs
and from the main bar of the common
because its deleted
but it stays also after refresh
see in the print screen that i voter for delete
but it changed to rejected

lets also look at it in the meeting at 14:00

Image

@andreymikhadyuk
Copy link
Collaborator

@NoamQA It is strange that it is Rejected, but the common/space will be deleted only when status is Approved.

@andreymikhadyuk
Copy link
Collaborator

should be checked by BE side why Noam gets Rejected.
@danielr18

@elatif2020
Copy link
Collaborator

elatif2020 commented Aug 2, 2023

I added another ticket for this vote outcome issue, here https://github.com/daostack/common-backend/issues/2008
I'm closing this ticket, If I understand correctly the original issue in the title here was closed

@elatif2020 elatif2020 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants